Labels Milestones

Analytic unit type and meta in db #65 #72

Merged

glitch4347 merged 6 commits from analytic-unit-type-and-meta-in-db-#65 into main 3 years ago

Conversation 0 Commits 6 Files Changed 8

glitch4347 commented 3 years ago (Migrated from github.com)

Owner

Closes https://github.com/hastic/hastic/issues/65

Changes

• ramade from scratch AnlyticSerivice::patch_config: now it extracts data from db instead of Default
• new method AnalyticUnitConfig::patch_needs_learning which replaces a bit logic of AnalyticUnitConfig::patch. AnalyticUnitConfig::patch is maybe deprecated now
• new methods in PatchConfig and AnalyticUnitService for resolving / setting configs by it -- it's still hack where id and type_id correspond to each other

Other

• code format

Notes

• the code is really ugly it this point and logic of id's vs PatchConfig should be rethought
• logic of need_learning overlaps with logic of same_type in AnalyticService::patch_config
• it's not that update db work in blocking way

Closes https://github.com/hastic/hastic/issues/65 ## Changes * ramade from scratch `AnlyticSerivice::patch_config`: now it extracts data from db instead of `Default` * new method `AnalyticUnitConfig::patch_needs_learning` which replaces a bit logic of `AnalyticUnitConfig::patch`. `AnalyticUnitConfig::patch` is maybe deprecated now * new methods in `PatchConfig` and `AnalyticUnitService` for resolving / setting configs by it -- it's still hack where `id` and `type_id` correspond to each other ## Other * code format ## Notes * the code is really ugly it this point and logic of id's vs PatchConfig should be rethought * logic of `need_learning` overlaps with logic of `same_type` in `AnalyticService::patch_config` * it's not that update db work in blocking way

rozetko (Migrated from github.com) approved these changes 3 years ago

Reviewers

rozetko

The pull request has been merged as 278ea473f2.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

rozetko

Labels

Apply labels

Clear labels

bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested refactoring wontfix
This will not be worked on

No Label bug documentation duplicate enhancement good first issue help wanted invalid question refactoring wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.