PoC: improve error handling #45
Merged
rozetko
merged 1 commits from poc-improve-error-handling
into main
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'poc-improve-error-handling'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Related issue: #42
This PR updates
.learn()
AnalyticUnit
s' method to return error instead of panicking. It'd be great to do the same for other methodsChanges:
.learn()
return type fromLearningResult
toanyhow::Result<LearningResult>
unwrap
s in.learn()
mostlyDatasourceError
fromLearningResult
LearningDatasourceError
fromResponseType
(Err
is used instead)P.S. it'd be nice to create custom error types also
Reviewers
3cc85c289f
.