Labels Milestones

Make influx work in Docker #110

Merged

rozetko merged 4 commits from influx-docker into main 2 years ago

Conversation 1 Commits 4 Files Changed 3

rozetko commented 2 years ago

Owner

This PR fixes the issue reported here: https://github.com/hastic/hastic/issues/110. The issue is that hastic inside Docker can't connect to Influx.

It happens because there is a default Prometheus config inside the Docker container which has priority over Influx config.

Changes:

• config.example.toml: comment out everything except port. Now hastic won't use prometheus config from config.toml instead of Influx config from environment variables
• config.rs: print all config values so that we can easily see such problems in the future (we were only printing environment variables before)

Other changes:

• docker-compose.yml: rm network-mode: host because hastic doesn't need it

This PR fixes the issue reported here: https://github.com/hastic/hastic/issues/110. The issue is that hastic inside Docker can't connect to Influx. It happens because there is a default Prometheus config inside the Docker container which has priority over Influx config. Changes: - `config.example.toml`: comment out everything except `port`. Now hastic won't use `prometheus` config from `config.toml` instead of Influx config from environment variables - `config.rs`: print all config values so that we can easily see such problems in the future (we were only printing environment variables before) Other changes: - `docker-compose.yml`: rm `network-mode: host` because hastic doesn't need it

rozetko added 3 commits 2 years ago

e16410d407 make influx work in docker

57854909f9 print config on start

f4226a5245 upd config example

rozetko requested review from glitch4347 2 years ago

rozetko requested review from vargburz 2 years ago

rozetko added 1 commit 2 years ago

fce0f30e9e docker-compose: rm "network-mode: host" option

rozetko merged commit abbadbc155 into main 2 years ago

rozetko deleted branch influx-docker 2 years ago

rozetko referenced this issue from a commit 2 years ago

Merge pull request 'Make influx work in Docker' (#110) from influx-docker into main

glitch4347 commented 2 years ago

Owner

@rozetko damn bro this is cool. tnx

@rozetko damn bro this is cool. tnx

Reviewers

vargburz was requested for review 2 years ago

glitch4347 was requested for review 2 years ago

The pull request has been merged as abbadbc155.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

vargburz

glitch4347

Labels

Apply labels

Clear labels

bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested refactoring wontfix
This will not be worked on

No Label bug documentation duplicate enhancement good first issue help wanted invalid question refactoring wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.