Browse Source

remove unneeded lines according to PR review

add type to some fields
master
sanke 6 years ago
parent
commit
acc2a5724a
  1. 6
      src/controllers/analytic_controller.ts
  2. 3
      src/models/analytic_unit.ts

6
src/controllers/analytic_controller.ts

@ -34,9 +34,9 @@ export class AnalyticController {
private _newAnalyticUnit: AnalyticUnit = null; private _newAnalyticUnit: AnalyticUnit = null;
private _creatingNewAnalyticType: boolean = false; private _creatingNewAnalyticType: boolean = false;
private _savingNewAnalyticUnit: boolean = false; private _savingNewAnalyticUnit: boolean = false;
private _tempIdCounted = -1; private _tempIdCounted: number = -1;
private _graphLocked = false; private _graphLocked: boolean = false;
private _currentColorIndex = 0; private _currentColorIndex: number = 0;
private _statusRunners: Set<AnalyticUnitId> = new Set<AnalyticUnitId>(); private _statusRunners: Set<AnalyticUnitId> = new Set<AnalyticUnitId>();

3
src/models/analytic_unit.ts

@ -3,9 +3,7 @@ import { SegmentArray } from './segment_array';
import { Segment, SegmentId } from './segment'; import { Segment, SegmentId } from './segment';
import { Metric } from './metric'; import { Metric } from './metric';
import { ANALYTIC_UNIT_COLORS } from '../colors';
import _ from 'lodash'; import _ from 'lodash';
import { AnalyticController } from 'controllers/analytic_controller';
export type AnalyticSegmentPair = { anomalyType: AnalyticUnit, segment: AnalyticSegment }; export type AnalyticSegmentPair = { anomalyType: AnalyticUnit, segment: AnalyticSegment };
@ -31,7 +29,6 @@ export class AnalyticUnit {
private _status: string; private _status: string;
private _error: string; private _error: string;
private _metric: Metric; private _metric: Metric;
private _color: string;
private _alertEnabled?: boolean; private _alertEnabled?: boolean;

Loading…
Cancel
Save