Browse Source

Merge branch 'do-not-highlight-nil-metric' into 'main'

fix non-existing metrics being highlighted on hover

See merge request chartwerk/line-pod!25
pull/1/head
rozetko 2 years ago
parent
commit
fa632d35a9
  1. 2
      package.json
  2. 11
      src/index.ts

2
package.json

@ -1,6 +1,6 @@
{
"name": "@chartwerk/line-pod",
"version": "0.6.5",
"version": "0.6.6",
"description": "Chartwerk line chart",
"main": "dist/index.js",
"scripts": {

11
src/index.ts

@ -290,15 +290,14 @@ export class LinePod extends ChartwerkPod<LineTimeSerie, LineOptions> {
let points = []; // datapoints in each metric that is closest to xValue/yValue position
this.series.visibleSeries.forEach((serie: LineTimeSerie) => {
const closestDatapoint = this.getClosestDatapoint(serie, xValue, yValue);
if(closestDatapoint === undefined) {
if(_.isNil(closestDatapoint) || _.isNil(closestDatapoint[0])) {
this.hideCrosshairCircle(serie.idx);
return;
} else {
const xPosition = this.state.xScale(closestDatapoint[0]);
const yPosition = this.state.yScale(closestDatapoint[1]);
this.moveCrosshairCircle(xPosition, yPosition, serie.idx);
}
const xPosition = this.state.xScale(closestDatapoint[0]);
const yPosition = this.state.yScale(closestDatapoint[1]);
this.moveCrosshairCircle(xPosition, yPosition, serie.idx);
points.push({
value: closestDatapoint,
color: serie.color,

Loading…
Cancel
Save