hastic
/
hastic
4
1
Fork 0
Code Issues 61 Pull Requests Releases Activity
Labels Milestones

PoC: improve error handling #45

Merged
rozetko merged 1 commits from poc-improve-error-handling into main 2 years ago
Conversation 0 Commits 1 Files Changed 6
rozetko commented 2 years ago (Migrated from github.com)
Owner

Related issue: #42

This PR updates .learn() AnalyticUnits' method to return error instead of panicking. It'd be great to do the same for other methods

Changes:

  • analytic units:
    • change .learn() return type from LearningResult to anyhow::Result<LearningResult>
    • get rid of unwraps in .learn() mostly
  • remove DatasourceError from LearningResult
  • remove LearningDatasourceError from ResponseType (Err is used instead)

P.S. it'd be nice to create custom error types also

Related issue: #42 This PR updates `.learn()` `AnalyticUnit`s' method to return error instead of panicking. It'd be great to do the same for other methods Changes: - analytic units: - change `.learn()` return type from `LearningResult` to `anyhow::Result<LearningResult>` - get rid of `unwrap`s in `.learn()` mostly - remove `DatasourceError` from `LearningResult` - remove `LearningDatasourceError` from `ResponseType` (`Err` is used instead) P.S. it'd be nice to create custom error types also
glitch4347 (Migrated from github.com) approved these changes 2 years ago

Reviewers

glitch4347
The pull request has been merged as 3cc85c289f.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
glitch4347
Labels
Apply labels
Clear labels
bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested refactoring wontfix
This will not be worked on
No Label bug documentation duplicate enhancement good first issue help wanted invalid question refactoring wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'poc-improve-error-handling'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes