Labels Milestones

Bucket detection window for pattern analytic unit #83 #85

Merged

glitch4347 merged 4 commits from backet-detection-window-for-pattern-analytic-unit-#83 into main 3 years ago

Conversation 0 Commits 4 Files Changed 3

glitch4347 commented 3 years ago (Migrated from github.com)

Owner

Closes https://github.com/hastic/hastic/issues/83

Changes

• MetricService now has get_detection_step method which return 10 -- it's a hack
• PatternAnalyticUnit returns avg_pattern_length in get_detection_window -- it's also not 100% right cuz there used unwrap and formally learning results can be None

Notes

This PR doesn't really introduce bucket and query from metrics_service used to get data for detection

Closes https://github.com/hastic/hastic/issues/83 ## Changes * MetricService now has `get_detection_step` method which return `10` -- it's a hack * `PatternAnalyticUnit` returns `avg_pattern_length` in `get_detection_window` -- it's also not 100% right cuz there used `unwrap` and formally learning results can be `None` ## Notes This PR doesn't really introduce bucket and query from `metrics_service` used to get data for detection

glitch4347 (Migrated from github.com) reviewed 3 years ago

server/src/services/analytic_service/detection_runner.rs

glitch4347 (Migrated from github.com) commented 3 years ago

Owner

```suggestion ```

rozetko (Migrated from github.com) approved these changes 3 years ago

Reviewers

rozetko

The pull request has been merged as 4f66b59b7e.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

rozetko

Labels

Apply labels

Clear labels

bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested refactoring wontfix
This will not be worked on

No Label bug documentation duplicate enhancement good first issue help wanted invalid question refactoring wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.