Bucket detection window for pattern analytic unit #83 #85

Merged
glitch4347 merged 4 commits from backet-detection-window-for-pattern-analytic-unit-#83 into main 2 years ago
glitch4347 commented 2 years ago (Migrated from github.com)
Owner

Closes https://github.com/hastic/hastic/issues/83

Changes

  • MetricService now has get_detection_step method which return 10 -- it's a hack
  • PatternAnalyticUnit returns avg_pattern_length in get_detection_window -- it's also not 100% right cuz there used unwrap and formally learning results can be None

Notes

This PR doesn't really introduce bucket and query from metrics_service used to get data for detection

Closes https://github.com/hastic/hastic/issues/83 ## Changes * MetricService now has `get_detection_step` method which return `10` -- it's a hack * `PatternAnalyticUnit` returns `avg_pattern_length` in `get_detection_window` -- it's also not 100% right cuz there used `unwrap` and formally learning results can be `None` ## Notes This PR doesn't really introduce bucket and query from `metrics_service` used to get data for detection
glitch4347 (Migrated from github.com) reviewed 2 years ago
glitch4347 (Migrated from github.com) commented 2 years ago
Owner
```suggestion ```
rozetko (Migrated from github.com) approved these changes 2 years ago

Reviewers

The pull request has been merged as 4f66b59b7e.
Sign in to join this conversation.
Loading…
There is no content yet.