chartwerk
/
scatter-pod
4
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity
Labels Milestones

init React component (TODO: use workspaces properly) #2

Merged
rozetko merged 1 commits from init-react-component into main 2 weeks ago
Conversation 0 Commits 1 Files Changed 12
rozetko commented 2 weeks ago
Owner

Same way as in line-pod

While doing this, I found out that workspaces are not used properly in line-pod. There is "@chartwerk/line-pod": "workspaces:*" in package.json but in yarn.lock you can see that @chartwerk/line-pod is installed from npm, not workspaces:

https://code.corpglory.net/chartwerk/line-pod/src/branch/main/react/yarn.lock#L18-L25

It works somehow but we should fix it both in line-pod and scatter-pod

Same way as in line-pod While doing this, I found out that workspaces are not used properly in line-pod. There is `"@chartwerk/line-pod": "workspaces:*"` in `package.json` but in `yarn.lock` you can see that `@chartwerk/line-pod` is installed from `npm`, not `workspaces`: https://code.corpglory.net/chartwerk/line-pod/src/branch/main/react/yarn.lock#L18-L25 It works somehow but we should fix it both in line-pod and scatter-pod
rozetko added 1 commit 2 weeks ago
rozetko merged commit 07812328ec into main 2 weeks ago
rozetko deleted branch init-react-component 2 weeks ago
The pull request has been merged as 07812328ec.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'init-react-component'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes