From c7284f43051b840850f592cfdb0a475cb19fd552 Mon Sep 17 00:00:00 2001
From: Alexey Velikiy <cg@corpglory.com>
Date: Mon, 3 Jan 2022 12:41:56 +0300
Subject: [PATCH] todos++

---
 server/src/services/analytic_service/detection_runner.rs | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/server/src/services/analytic_service/detection_runner.rs b/server/src/services/analytic_service/detection_runner.rs
index ce1d804..f5362dc 100644
--- a/server/src/services/analytic_service/detection_runner.rs
+++ b/server/src/services/analytic_service/detection_runner.rs
@@ -33,7 +33,6 @@ impl DetectionRunner {
     }
 
     pub fn run(&mut self, from: u64) {
-        // TODO: get last detection timestamp from persistance
         // TODO: set last detection from "now"
         if self.running_handler.is_some() {
             self.running_handler.as_mut().unwrap().abort();
@@ -46,8 +45,8 @@ impl DetectionRunner {
             async move {
                 // TODO: run detection "from" for big timespan
                 // TODO: parse detections to webhooks
-                // TODO: define window for detection
                 // TODO: handle case when detection is in the end and continues after "now"
+                //       it's better to make an issue on github
 
                 let window_size = au.as_ref().read().await.get_detection_window();
                 let detection_step = ms.get_detection_step();
@@ -72,7 +71,7 @@ impl DetectionRunner {
                         println!("detection: {} {}", d.0, d.1);
                     }
 
-                    // TODO: set info about detections to tx
+                    // TODO: send info about detections to tx
 
                     match tx
                         .send(AnalyticServiceMessage::Response(Ok(