basic range deletion

client/src/components/Graph.vue

@@ -6,7 +6,7 @@
 import { defineComponent } from 'vue';
 import { HasticPod, TimeRange } from "./hastic_pod";
 import { getMetrics } from '../services/metrics.service';
-import { getSegments, postSegment } from '../services/segments';
+import { getSegments, postSegment, deleteSegment } from '../services/segments';
 import { LineTimeSerie } from "@chartwerk/line-pod";
 
 import { SegmentArray } from '@/types/segment_array';
@@ -58,6 +58,21 @@ async function addSegment(segment: Segment): Promise<SegmentId> {
   }
 }
 
+// TODO: move to store
+async function _deleteSegment(from: number, to: number): Promise<SegmentId> {
+  try {
+    const id = await deleteSegment(from, to);
+    return id;
+  } catch (e) {
+    this.$notify({
+      title: "Error during saving segment",
+      text: e,
+      type: 'error'
+    });
+    console.error(e);
+  }
+}
+
 export default defineComponent({
   name: 'Graph',
   props: {},
@@ -70,6 +85,7 @@ export default defineComponent({
       document.getElementById('chart'),
       resolveData.bind(this),
       addSegment.bind(this),
+      _deleteSegment.bind(this),
       s
     );
     pod.render();

client/src/components/hastic_pod/index.ts

@@ -5,22 +5,29 @@ import { ANALYTIC_UNIT_COLORS } from "@/types/colors"
 import { Segment, SegmentId } from "@/types/segment";
 
 export type TimeRange = { from: number, to: number };
-export type UpdateDataCallback = (range: TimeRange) => Promise<{ 
-  timeserie: LineTimeSerie[], 
+export type UpdateDataCallback = (range: TimeRange) => Promise<{
+  timeserie: LineTimeSerie[],
   segments: Segment[]
 }>;
 export type CreateSegmentCallback = (segment: Segment) => Promise<SegmentId>;
+export type DeleteSegmentCallback = (from: number, to: number) => Promise<number>;
 
 export class HasticPod extends LinePod {
 
   private _udc: UpdateDataCallback;
   private _csc: CreateSegmentCallback;
+  private _dsc: DeleteSegmentCallback;
 
   private _ctrlKeyIsDown: boolean;
-  private _ctrlBrush: boolean;
-  
+  private _dKeyIsDown: boolean;
+  private _labelBrush: boolean;
+  private _deleteBrush: boolean;
+
   constructor(
-    el: HTMLElement, udc: UpdateDataCallback, csc: CreateSegmentCallback,
+    el: HTMLElement, 
+    udc: UpdateDataCallback, 
+    csc: CreateSegmentCallback,
+    dsc: DeleteSegmentCallback,
     private _segmentSet: SegmentsSet<Segment>
   ) {
     super(el, undefined, {
@@ -33,18 +40,25 @@ export class HasticPod extends LinePod {
     });
 
     this._csc = csc;
+    this._dsc = dsc;
     this._ctrlKeyIsDown = false;
-    this._ctrlBrush = false;
+    this._labelBrush = false;
 
     window.addEventListener("keydown", e => {
       if(e.code == "ControlLeft") {
         this._ctrlKeyIsDown = true;
       }
+      if(e.code == 'KeyD') {
+        this._dKeyIsDown = true;
+      }
     });
     window.addEventListener("keyup", (e) => {
       if(e.code == "ControlLeft") {
         this._ctrlKeyIsDown = false;
       }
+      if(e.code == 'KeyD') {
+        this._dKeyIsDown = false;
+      }
     });
 
     this._udc = udc;
@@ -63,19 +77,21 @@ export class HasticPod extends LinePod {
 
     if(this.state?.xValueRange !== undefined) {
       [from, to] = this.state?.xValueRange;
-      console.log('took from range');
+      console.log('took from range from state');
+    } else {
+      console.log('took from range from default');
     }
     console.log(from + " ---- " + to);
-    
+
     this._udc({ from, to })
-      .then(resp => { 
+      .then(resp => {
         this.updateData(resp.timeserie);
         this.updateSegments(resp.segments);
       })
       .catch(() => { /* set "error" message */ })
   }
 
-  protected addEvents(): void {    
+  protected addEvents(): void {
     this.initBrush();
     this.initPan();
 
@@ -88,11 +104,15 @@ export class HasticPod extends LinePod {
 
   protected onBrushStart(): void {
     if(this._ctrlKeyIsDown) {
-      this._ctrlBrush = true;
-      this.svg.select('.selection').attr('fill', 'red')
+      this._labelBrush = true;
+      this.svg.select('.selection')
+        .attr('fill', 'red')
+    } else if (this._dKeyIsDown) {
+      this._deleteBrush = true;
+      this.svg.select('.selection')
+        .attr('fill', 'blue')
     }
 
-    // this.in
     // TODO: move to state
     this.isBrushing === true;
     const selection = this.d3.event.selection;
@@ -103,12 +123,12 @@ export class HasticPod extends LinePod {
   }
 
   protected onBrushEnd(): void {
-    if(!this._ctrlBrush) {
+    if(!this._labelBrush && !this._deleteBrush) {
       super.onBrushEnd();
     } else {
       const extent = this.d3.event.selection;
       this.isBrushing === false;
-      this._ctrlBrush = false;
+      this._labelBrush = false;
       if(extent === undefined || extent === null || extent.length < 2) {
         return;
       }
@@ -117,8 +137,13 @@ export class HasticPod extends LinePod {
 
       const startTimestamp = this.xScale.invert(extent[0]);
       const endTimestamp = this.xScale.invert(extent[1]);
-      
-      this.addSegment(startTimestamp, endTimestamp);
+
+      if(this._labelBrush) {
+        this.addSegment(startTimestamp, endTimestamp);
+      }
+      if(this._deleteBrush) {
+        this.deleteSegment(startTimestamp, endTimestamp);
+      }
     }
   }
 
@@ -134,7 +159,7 @@ export class HasticPod extends LinePod {
     }
 
     const segment = new Segment(id, from, to);
-    //const storedId = 
+    //const storedId =
     await this._csc(segment);
     this.fetchData();
     // segment.id = storedId;
@@ -143,6 +168,21 @@ export class HasticPod extends LinePod {
     // this.renderSegment(segment);
   }
 
+  protected async deleteSegment(from: number, to: number) {
+    from = Math.floor(from);
+    to = Math.ceil(to);
+
+    if (from > to) {
+      const t = from;
+      from = to;
+      to = t;
+    }
+
+    await this._dsc(from, to);
+    this.fetchData();
+
+  }
+
   protected renderSegments() {
     const segments = this._segmentSet.getSegments();
     for (const s in segments) {
@@ -168,17 +208,12 @@ export class HasticPod extends LinePod {
   }
 
   private async _updateRange(range: AxisRange[]) {
-    console.log('update range');
-    console.log(range);
-    
-    const resp = await this._udc({ from: range[0][0], to: range[0][1] });
-    const options = { axis: { x: { range: range[0] } } };
-    this.updateData(resp.timeserie, options);
-    this.updateSegments(resp.segments);
+    // in assumption that range have been changed
+    this.fetchData();
   }
 
   private _zoomOut({x, y}) {
-    console.log(`${x} -- ${y}`);
+    this.fetchData();
   }
 
   protected updateSegments(segments: Segment[]) {

client/src/services/segments.ts

@@ -22,3 +22,9 @@ export async function postSegment(segment: Segment): Promise<SegmentId> {
   const resp = await axios.post(SEGMENTS_API_URL, segment);
   return resp['data']['id'];
 }
+
+export async function deleteSegment(from: number, to: number): Promise<SegmentId> {
+  const uri = SEGMENTS_API_URL + `?from=${from}&to=${to}`;
+  const resp = await axios.delete(uri);
+  return resp['data']['count'];
+}

server/src/api/segments.rs

@@ -9,7 +9,7 @@ pub mod filters {
     ) -> impl Filter<Extract = impl warp::Reply, Error = warp::Rejection> + Clone {
         list(db.clone()).or(create(db.clone()))
         // .or(update(db.clone()))
-        // .or(delete(db.clone()))
+        .or(delete(db.clone()))
     }
 
     /// GET /segments?from=3&to=5
@@ -34,6 +34,17 @@ pub mod filters {
             .and_then(handlers::create)
     }
 
+    /// POST /segments with JSON body
+    pub fn delete(
+        db: Db,
+    ) -> impl Filter<Extract = impl warp::Reply, Error = warp::Rejection> + Clone {
+        warp::path!("segments")
+            .and(warp::delete())
+            .and(warp::query::<ListOptions>())
+            .and(with_db(db))
+            .and_then(handlers::delete)
+    }
+
     fn with_db(db: Db) -> impl Filter<Extract = (Db,), Error = std::convert::Infallible> + Clone {
         warp::any().map(move || db.clone())
     }
@@ -44,6 +55,7 @@ mod handlers {
     use hastic::services::data_service::Segment;
 
     use super::models::{CreateResponse, Db, ListOptions};
+    use crate::api;
     use crate::api::BadQuery;
     use crate::api::API;
 
@@ -66,6 +78,14 @@ mod handlers {
             }
         }
     }
+
+    pub async fn delete(opts: ListOptions, db: Db) -> Result<impl warp::Reply, warp::Rejection> {
+        match db.read().delete_segments_in_range(opts.from, opts.to) {
+            Ok(count) => Ok(API::json(&api::Message{ message: count.to_string() })),
+            Err(e) => Err(warp::reject::custom(BadQuery)),
+        }
+    }
+
 }
 
 mod models {

server/src/services/data_service.rs

@@ -112,6 +112,15 @@ impl DataService {
         Ok(res)
     }
 
+    pub fn delete_segments_in_range(&self, from: u64, to: u64) -> anyhow::Result<usize> {
+        let conn = self.connection.lock().unwrap();
+        let res = conn.execute(
+            "DELETE FROM segment where ?1 <= start AND end <= ?2",
+            params![from, to],
+        )?;
+        return Ok(res);
+    }
+
     pub fn delete_segments(&self, ids: &Vec<SegmentId>) -> anyhow::Result<usize> {
         if ids.len() == 0 {
             return Ok(0);