From 4774f5d6b502ee502bdddce409eea7e1c64a61e3 Mon Sep 17 00:00:00 2001 From: rozetko Date: Wed, 22 Dec 2021 21:01:57 +0300 Subject: [PATCH 1/2] LearningStatus::Error : error message argument --- server/src/services/analytic_service/analytic_service.rs | 4 ++-- server/src/services/analytic_service/types.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/src/services/analytic_service/analytic_service.rs b/server/src/services/analytic_service/analytic_service.rs index 090f108..2156fa0 100644 --- a/server/src/services/analytic_service/analytic_service.rs +++ b/server/src/services/analytic_service/analytic_service.rs @@ -263,9 +263,9 @@ impl AnalyticService { } } // TODO: create custom DatasourceError error type - Err(_) => { + Err(err) => { self.analytic_unit = None; - self.analytic_unit_learning_status = LearningStatus::Error; + self.analytic_unit_learning_status = LearningStatus::Error(err.to_string()); } } } diff --git a/server/src/services/analytic_service/types.rs b/server/src/services/analytic_service/types.rs index 6d1efbe..527ede7 100644 --- a/server/src/services/analytic_service/types.rs +++ b/server/src/services/analytic_service/types.rs @@ -22,7 +22,7 @@ pub enum LearningStatus { Initialization, Starting, Learning, - Error, + Error(String), Ready, } From ef572afcaa18a2896a3f1060d3de82a9bed4142a Mon Sep 17 00:00:00 2001 From: rozetko Date: Wed, 22 Dec 2021 21:02:32 +0300 Subject: [PATCH 2/2] prettify "too short timeserie to learn from" error message --- .../analytic_service/analytic_unit/anomaly_analytic_unit.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/services/analytic_service/analytic_unit/anomaly_analytic_unit.rs b/server/src/services/analytic_service/analytic_unit/anomaly_analytic_unit.rs index cf23f1d..a33202d 100644 --- a/server/src/services/analytic_service/analytic_unit/anomaly_analytic_unit.rs +++ b/server/src/services/analytic_service/analytic_unit/anomaly_analytic_unit.rs @@ -50,7 +50,7 @@ impl SARIMA { // TODO: trend detection if ts.len() < 2 { - return Err(anyhow::format_err!("to short timeserie to learn from")); + return Err(anyhow::format_err!("too short timeserie to learn from, timeserie length: {}", ts.len())); } // TODO: ensure capacity with seasonality size let mut res_ts = Vec::<(u64, f64)>::new();