From 1698f4b640e65b649dfe142cc2e4a4a693478a86 Mon Sep 17 00:00:00 2001
From: Alexey Velikiy <av@corpglory.com>
Date: Fri, 24 Aug 2018 23:50:11 +0300
Subject: [PATCH] improve error handling from grafana_service

---
 server/src/controllers/analytics_controller.ts |  3 ++-
 server/src/services/grafana_service.ts         | 15 ++++++++++-----
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/server/src/controllers/analytics_controller.ts b/server/src/controllers/analytics_controller.ts
index 98e1091..355ecc9 100644
--- a/server/src/controllers/analytics_controller.ts
+++ b/server/src/controllers/analytics_controller.ts
@@ -108,7 +108,8 @@ export async function runLearning(id: AnalyticUnit.AnalyticUnitId) {
     await AnalyticUnit.setStatus(id, AnalyticUnit.AnalyticUnitStatus.READY);
 
   } catch (err) {
-    await AnalyticUnit.setStatus(id, AnalyticUnit.AnalyticUnitStatus.FAILED, err);
+    let message = err.message || JSON.stringify(err);
+    await AnalyticUnit.setStatus(id, AnalyticUnit.AnalyticUnitStatus.FAILED, message);
     if(previousLastPredictionTime !== undefined) {
       await AnalyticUnit.setPredictionTime(id, previousLastPredictionTime);
     }
diff --git a/server/src/services/grafana_service.ts b/server/src/services/grafana_service.ts
index fd97218..2d05223 100644
--- a/server/src/services/grafana_service.ts
+++ b/server/src/services/grafana_service.ts
@@ -1,14 +1,12 @@
 import { Metric } from '../models/metric_model';
-
 import { HASTIC_API_KEY } from '../config';
-
 import { URL } from 'url';
 import axios from 'axios';
 
 
 const CHUNK_SIZE = 50000;
+const QUERY_TIME_REPLACE_REGEX = /(WHERE time >[^A-Z]+)/;
 
-export type Timestamp = number;
 /**
  * @param metric to query to Grafana
  * @returns [time, value][] array
@@ -32,7 +30,11 @@ export async function queryByMetric(metric: Metric, panelUrl: string): Promise<[
   let data = [];
   while (offset <= records) {
     let paramsClone = Object.assign({}, params);
-    paramsClone.q = paramsClone.q.replace(/(WHERE time >[^A-Z]+)/, `LIMIT ${limit} OFFSET ${offset}`);
+    let replacedQ = paramsClone.q.replace(QUERY_TIME_REPLACE_REGEX, `LIMIT ${limit} OFFSET ${offset}`);
+    if(replacedQ === paramsClone.q) {
+      throw new Error(`Query "${paramsClone.q}" is not replaced with LIMIT/OFFSET oeprators`)
+    }
+    paramsClone.q = replacedQ;
 
     let chunk = await queryGrafana(url, paramsClone);
     data = data.concat(chunk);
@@ -61,7 +63,10 @@ async function queryGrafana(url: string, params: any) {
   try {
     res = await axios.get(url, { params, headers });
   } catch (e) {
-    console.error(`Error while getting data from Grafana: ${e}`);
+    if(e.response.status === 401) {
+      throw new Error('Unauthorized. Check the $HASTIC_API_KEY');
+    }
+    throw new Error(e.message);
   }
 
   if (res.data.results === undefined) {