From 2e156ad46bd7ca5c98491459f3993a13a0dbf8bc Mon Sep 17 00:00:00 2001 From: glitch4347 Date: Sun, 3 Dec 2023 14:02:08 +0100 Subject: [PATCH 1/2] add node_resolutinos for linking case & update readme --- README.md | 20 +++++++++++++++++++- build/webpack.base.conf.js | 4 ++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 08801bc..0346816 100755 --- a/README.md +++ b/README.md @@ -23,4 +23,22 @@ [Live Chart](https://code.corpglory.net/chartwerk/line-pod/src/branch/main/examples/demo_live.html) -[Vertical Chart](https://code.corpglory.net/chartwerk/line-pod/src/branch/main/examples/demo_vertical.html) \ No newline at end of file +[Vertical Chart](https://code.corpglory.net/chartwerk/line-pod/src/branch/main/examples/demo_vertical.html) + + +### Development + +If you want to link `core` then clone it to same directory and then run + +``` +yarn link ../core +``` + +but don't add `resolutions` logic to `package.json` + +then run + +``` +yarn install +yarn dev +``` \ No newline at end of file diff --git a/build/webpack.base.conf.js b/build/webpack.base.conf.js index f189e91..1e52c18 100755 --- a/build/webpack.base.conf.js +++ b/build/webpack.base.conf.js @@ -25,6 +25,10 @@ module.exports = { }, resolve: { extensions: ['.ts', '.js'], + // this is necessary for resolution of external libs like d3 in dev mode + // in linkind: webpack will take d3 from this node_modules but not from + // internal so you get one version of d3 + modules: [path.resolve(__dirname, '../node_modules'), 'node_modules'] }, output: { filename: 'index.js', -- 2.34.1 From 833780105a816e8871925ba7510c19e46285f822 Mon Sep 17 00:00:00 2001 From: glitch4347 Date: Sun, 3 Dec 2023 14:03:54 +0100 Subject: [PATCH 2/2] fx type in conf --- build/webpack.base.conf.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/webpack.base.conf.js b/build/webpack.base.conf.js index 1e52c18..97b8a60 100755 --- a/build/webpack.base.conf.js +++ b/build/webpack.base.conf.js @@ -26,7 +26,7 @@ module.exports = { resolve: { extensions: ['.ts', '.js'], // this is necessary for resolution of external libs like d3 in dev mode - // in linkind: webpack will take d3 from this node_modules but not from + // when core is linked: webpack will take d3 from this node_modules but not from // internal so you get one version of d3 modules: [path.resolve(__dirname, '../node_modules'), 'node_modules'] }, -- 2.34.1