@rozetko argues that it's made by design. But I belive that in line pod it's well defined and it's this.state.xValueRange = [this.state.xValueRange[0] - xInterval / 2, this.state.xValueRange[1] + xInterval / 2];
@rozetko argues that it's made by design. But I belive that in line pod it's well defined and it's `this.state.xValueRange = [this.state.xValueRange[0] - xInterval / 2, this.state.xValueRange[1] + xInterval / 2];`
how made in https://code.corpglory.net/chartwerk/line-pod/src/branch/main/src/index.ts#L416
what do you think?
@glitch4347 yeah, I think it'd be nice if line-pod returns you the range to set
P.S. there is a thing I don't like in here (https://code.corpglory.net/chartwerk/line-pod/src/branch/main/src/index.ts#L416): line-pod updates `xValueRange` and re-renders before calling `zoomOut` callback
It's necessary to get range on zoomOut because user needs to compute the range by himself
@vargburz @rozetko we use this in react app also.
Can you validate please that it's actual issue please?
@rozetko argues that it's made by design. But I belive that in line pod it's well defined and it's
this.state.xValueRange = [this.state.xValueRange[0] - xInterval / 2, this.state.xValueRange[1] + xInterval / 2];
how made in https://code.corpglory.net/chartwerk/line-pod/src/branch/main/src/index.ts#L416
what do you think?
@rozetko if you don't want to set exact timerange then you can just ignore it and make your own logic
@glitch4347 yeah, I think it'd be nice if line-pod returns you the range to set
P.S. there is a thing I don't like in here (https://code.corpglory.net/chartwerk/line-pod/src/branch/main/src/index.ts#L416): line-pod updates
xValueRange
and re-renders before callingzoomOut
callback@rozetko I would also add that it's real behaviour
it's zooming out
I acidently pushed to main
8aca72ce04