ZoomOut range argument #45

Closed
opened 9 months ago by glitch4347 · 6 comments
Owner

It's necessary to get range on zoomOut because user needs to compute the range by himself

It's necessary to get range on zoomOut because user needs to compute the range by himself
Poster
Owner

@vargburz @rozetko we use this in react app also.
Can you validate please that it's actual issue please?

@vargburz @rozetko we use this in react app also. Can you validate please that it's actual issue please?
Poster
Owner

@rozetko argues that it's made by design. But I belive that in line pod it's well defined and it's this.state.xValueRange = [this.state.xValueRange[0] - xInterval / 2, this.state.xValueRange[1] + xInterval / 2];

how made in https://code.corpglory.net/chartwerk/line-pod/src/branch/main/src/index.ts#L416

what do you think?

@rozetko argues that it's made by design. But I belive that in line pod it's well defined and it's `this.state.xValueRange = [this.state.xValueRange[0] - xInterval / 2, this.state.xValueRange[1] + xInterval / 2];` how made in https://code.corpglory.net/chartwerk/line-pod/src/branch/main/src/index.ts#L416 what do you think?
Poster
Owner

@rozetko if you don't want to set exact timerange then you can just ignore it and make your own logic

@rozetko if you don't want to set exact timerange then you can just ignore it and make your own logic
Owner

@glitch4347 yeah, I think it'd be nice if line-pod returns you the range to set

P.S. there is a thing I don't like in here (https://code.corpglory.net/chartwerk/line-pod/src/branch/main/src/index.ts#L416): line-pod updates xValueRange and re-renders before calling zoomOut callback

@glitch4347 yeah, I think it'd be nice if line-pod returns you the range to set P.S. there is a thing I don't like in here (https://code.corpglory.net/chartwerk/line-pod/src/branch/main/src/index.ts#L416): line-pod updates `xValueRange` and re-renders before calling `zoomOut` callback
Poster
Owner

@rozetko I would also add that it's real behaviour

image

it's zooming out

@rozetko I would also add that it's real behaviour ![image](/attachments/b8dcacfa-e4c4-49b5-b245-a6a0a0fb3cbc) it's zooming out
Poster
Owner

I acidently pushed to main 8aca72ce04

I acidently pushed to main https://code.corpglory.net/chartwerk/line-pod/commit/8aca72ce0409aafc4827b8462d0e6d11bb878af5
glitch4347 closed this issue 9 months ago
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.