eevent callbacks vs abstract #18

Open
opened 12 months ago by glitch4347 · 2 comments
Owner

there is

export type Options = {
  margin?: Margin;
  eventsCallbacks?: {
    zoomIn?: (range: AxisRange[]) => void,
    panning?: (event: { ranges: AxisRange[], d3Event: any }) => void,
    panningEnd?: (range: AxisRange[]) => void,
    zoomOut?: (centers: {x: number, y: number}) => void,
    mouseMove?: (evt: any) => void,

and

protected abstract onMouseMove(): void;

there is recommendatyion to remove these abstract methods

there is ``` export type Options = { margin?: Margin; eventsCallbacks?: { zoomIn?: (range: AxisRange[]) => void, panning?: (event: { ranges: AxisRange[], d3Event: any }) => void, panningEnd?: (range: AxisRange[]) => void, zoomOut?: (centers: {x: number, y: number}) => void, mouseMove?: (evt: any) => void, ``` and ``` protected abstract onMouseMove(): void; ``` there is recommendatyion to remove these abstract methods
Poster
Owner

... and make at least these methods deprecated with warning and todo

... and make at least these methods deprecated with warning and todo
Poster
Owner

Partially it's implements in 5fc85d6329

Partially it's implements in https://code.corpglory.net/chartwerk/core/commit/5fc85d63292c3001f42eaf712e8b3b8f4d44d7a8
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.