demo/demo_pod.ts

@@ -51,6 +51,12 @@ class DemoPod extends ChartwerkPod<Serie, Options> {
       .attr('d', this.lineGenerator);
   }
 
+  onMouseMove(): void {}
+  onMouseOver(): void {}
+  onMouseOut(): void {}
+  onMouseClick(): void {}
+  renderSharedCrosshair(values): void {}
+  hideSharedCrosshair(): void {}
 }
 
 export { DemoPod };

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@chartwerk/core",
-  "version": "0.6.24",
+  "version": "0.6.22",
   "description": "Chartwerk core",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

src/VueChartwerkPodMixin.ts

@@ -39,9 +39,9 @@ export default {
   },
   methods: {
     // it's "abstract" method. "children" components should override it
-    render() {},
-    renderSharedCrosshair(values: { x?: number, y?: number }) {},
-    hideSharedCrosshair() {},
+    render() { },
+    renderSharedCrosshair(values: { x?: number, y?: number }) { },
+    hideSharedCrosshair() { },
     onPanningRescale(event) {
       this.pod.rescaleMetricAndAxis(event);
     },
@@ -63,9 +63,6 @@ export default {
       if(has(this.$listeners, 'zoomOut')) {
         this.options.events.zoomOut = this.zoomOut.bind(this);
       }
-      if(has(this.$listeners, 'mouseOver')) {
-        this.options.events.mouseOver = this.mouseOver.bind(this);
-      }
       if(has(this.$listeners, 'mouseMove')) {
         this.options.events.mouseMove = this.mouseMove.bind(this);
       }
@@ -100,9 +97,6 @@ export default {
     zoomOut(centers) {
       this.$emit('zoomOut', centers);
     },
-    mouseOver() {
-      this.$emit('mouseOver');
-    },
     mouseMove(evt) {
       this.$emit('mouseMove', evt);
     },

src/index.ts

@@ -37,7 +37,7 @@ import debounce from 'lodash/debounce';
 const DEFAULT_TICK_SIZE = 2;
 
 
-class ChartwerkPod<T extends Serie, O extends Options> {
+abstract class ChartwerkPod<T extends Serie, O extends Options> {
 
   protected series: CoreSeries<T>;
   protected options: CoreOptions<O>;
@@ -79,8 +79,7 @@ class ChartwerkPod<T extends Serie, O extends Options> {
     _series: T[] = [],
     _options: O
   ) {
-    // need to call explicitly because option lazyStyleTag
-    // in webpack style-loader
+    // TODO: test if it's necessary
     styles.use();
 
     this.options = new CoreOptions(_options);
@@ -152,13 +151,13 @@ class ChartwerkPod<T extends Serie, O extends Options> {
     this.series.updateSeries(newSeries);
   }
 
-  protected renderMetrics(): void {}
-  protected onMouseOver(): void {}
-  protected onMouseOut(): void {}
-  protected onMouseMove(): void {}
-  protected onMouseClick(): void {}
-  public renderSharedCrosshair(values: { x?: number, y?: number }): void {}
-  public hideSharedCrosshair(): void {}
+  protected abstract renderMetrics(): void;
+  protected abstract onMouseOver(): void;
+  protected abstract onMouseOut(): void;
+  protected abstract onMouseMove(): void;
+  protected abstract onMouseClick(): void;
+  public abstract renderSharedCrosshair(values: { x?: number, y?: number }): void;
+  public abstract hideSharedCrosshair(): void;
 
   protected initPodState(): void {
     const boxPararms = {

src/models/options.ts

@@ -226,12 +226,6 @@ export class CoreOptions<O extends Options> {
     }
   }
 
-  callbackMouseOver(): void {
-    if(has(this._options.events, 'mouseOver')) {
-      this._options.events.mouseOver();
-    }
-  }
-
   callbackMouseMove(event): void {
     if(has(this._options.events, 'mouseMove')) {
       this._options.events.mouseMove(event);

src/types.ts

@@ -20,7 +20,6 @@ export type Events = {
   panning?: (event: { ranges: AxisRange[], d3Event: any }) => void,
   panningEnd?: (range: AxisRange[]) => void,
   zoomOut?: (centers: {x: number, y: number}) => void,
-  mouseOver?: () => void,
   mouseMove?: (evt: any) => void,
   mouseClick?: (evt: any) => void,
   mouseOut?: () => void,