From 5fc85d63292c3001f42eaf712e8b3b8f4d44d7a8 Mon Sep 17 00:00:00 2001 From: glitch4347 Date: Sat, 16 Mar 2024 11:18:43 +0100 Subject: [PATCH] rm abstact keyword and methods --- demo/demo_pod.ts | 6 ------ src/index.ts | 16 ++++++++-------- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/demo/demo_pod.ts b/demo/demo_pod.ts index 7a2702c..7c47df5 100644 --- a/demo/demo_pod.ts +++ b/demo/demo_pod.ts @@ -51,12 +51,6 @@ class DemoPod extends ChartwerkPod { .attr('d', this.lineGenerator); } - onMouseMove(): void {} - onMouseOver(): void {} - onMouseOut(): void {} - onMouseClick(): void {} - renderSharedCrosshair(values): void {} - hideSharedCrosshair(): void {} } export { DemoPod }; diff --git a/src/index.ts b/src/index.ts index 3cdf66a..5264707 100644 --- a/src/index.ts +++ b/src/index.ts @@ -37,7 +37,7 @@ import debounce from 'lodash/debounce'; const DEFAULT_TICK_SIZE = 2; -abstract class ChartwerkPod { +class ChartwerkPod { protected series: CoreSeries; protected options: CoreOptions; @@ -151,13 +151,13 @@ abstract class ChartwerkPod { this.series.updateSeries(newSeries); } - protected abstract renderMetrics(): void; - protected abstract onMouseOver(): void; - protected abstract onMouseOut(): void; - protected abstract onMouseMove(): void; - protected abstract onMouseClick(): void; - public abstract renderSharedCrosshair(values: { x?: number, y?: number }): void; - public abstract hideSharedCrosshair(): void; + protected renderMetrics(): void {} + protected onMouseOver(): void {} + protected onMouseOut(): void {} + protected onMouseMove(): void {} + protected onMouseClick(): void { } + public renderSharedCrosshair(values: { x?: number, y?: number }): void {} + public hideSharedCrosshair(): void {} protected initPodState(): void { const boxPararms = {