Labels Milestones

direct Prometheus queries #1

Merged

rozetko merged 5 commits from direct-prometheus-queries into master 2 years ago

Conversation 0 Commits 5 Files Changed 21

rozetko commented 2 years ago

Owner

Good news is that Grafana returns raw datasource responses so the existing parsing methods aren't broken. We only need to update queries format.

Changes:

• init sample bin-file with a Prometheus query example
• update queryByMetrics to support both direct and Grafana-based queries
• update datasource config to specify whether a query is direct or Grafana-based

Other changes:

• fix bin build: tsc -> webpack (because tsc can't bundle everything into a single file)
• some renaming, e.g. DataKitError -> TsdbKitError
• remove package-lock.json (because we use yarn)

Notes:

• it doesn't support auth for now

TODO:

• Prometheus auth (https://code.corpglory.net/hastic/tsdb-kit/issues/4)
• it'd be good to add CLI arguments to bin/tsdb-kit.js for easier testing (https://code.corpglory.net/hastic/tsdb-kit/issues/2)
• update README with CLI examples (https://code.corpglory.net/hastic/tsdb-kit/issues/3)

Good news is that Grafana returns raw datasource responses so the existing parsing methods aren't broken. We only need to update queries format. Changes: - init sample bin-file with a Prometheus query example - update `queryByMetrics` to support both direct and Grafana-based queries - update datasource config to specify whether a query is direct or Grafana-based Other changes: - fix `bin` build: `tsc` -> `webpack` (because `tsc` can't bundle everything into a single file) - some renaming, e.g. `DataKitError` -> `TsdbKitError` - remove `package-lock.json` (because we use `yarn`) Notes: - it doesn't support auth for now TODO: - Prometheus auth (https://code.corpglory.net/hastic/tsdb-kit/issues/4) - it'd be good to add CLI arguments to `bin/tsdb-kit.js` for easier testing (https://code.corpglory.net/hastic/tsdb-kit/issues/2) - update README with CLI examples (https://code.corpglory.net/hastic/tsdb-kit/issues/3)

rozetko added 4 commits 2 years ago

3889b3dd64 rm package-lock

61562a9c94 fix bin build

fbf6c4949f upd types

de97390d1e sample bin file

rozetko added 1 commit 2 years ago

b8f1f27f1a some refactoring

rozetko changed title from WIP: direct Prometheus queries to direct Prometheus queries 2 years ago

rozetko requested review from glitch4347 2 years ago

rozetko requested review from vargburz 2 years ago

rozetko merged commit 8112975b12 into master 2 years ago

rozetko deleted branch direct-prometheus-queries 2 years ago

rozetko referenced this issue from a commit 2 years ago

Merge pull request 'direct Prometheus queries' (#1) from direct-prometheus-queries into master

Reviewers

glitch4347 was requested for review 2 years ago

vargburz was requested for review 2 years ago

The pull request has been merged as 8112975b12.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

glitch4347

vargburz

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.