Labels Milestones

active analytic unit #67

Merged

glitch4347 merged 14 commits from active-analytic-unit-#66 into main 2 years ago

Conversation 0 Commits 14 Files Changed 3

glitch4347 commented 2 years ago (Migrated from github.com)

Owner

closes https://github.com/hastic/hastic/issues/66

Changes

• active field in analytic_units.db
• serialize analytic unit config on creation
• get_active method which returns analytic_unit -- not used because get_active_config` actually used
• AnalyticUnitConfig::patch now also returns true as the last param if the patched config of the same type

Notes

• when analytic unit creates, it's type set to it's id -- it's a hack: 3 different ids correspond to 3 different types
• get_active_config has code duplication and really bad written
• I use to much of unwrap in this PR
• this PR overlaps with https://github.com/hastic/hastic/issues/65 -- there should be covered the usecase of proper persistance of analytic unit vs patching config

closes https://github.com/hastic/hastic/issues/66 ## Changes * `active` field in `analytic_units.db` * serialize analytic unit config on creation * `get_active` method which returns analytic_unit -- not used because get_active_config` actually used * `AnalyticUnitConfig::patch` now also returns `true` as the last param if the patched config of the same type ## Notes * when analytic unit creates, it's type set to it's id -- it's a hack: 3 different ids correspond to 3 different types * `get_active_config` has code duplication and really bad written * I use to much of `unwrap` in this PR * this PR overlaps with https://github.com/hastic/hastic/issues/65 -- there should be covered the usecase of proper persistance of analytic unit vs patching config

glitch4347 (Migrated from github.com) reviewed 2 years ago

server/src/services/analytic_unit_service.rs

glitch4347 (Migrated from github.com) commented 2 years ago

Owner

}

```suggestion } ```

rozetko (Migrated from github.com) approved these changes 2 years ago

Reviewers

rozetko

The pull request has been merged as f1d31b9637.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

rozetko

Labels

Apply labels

Clear labels

bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested refactoring wontfix
This will not be worked on

No Label bug documentation duplicate enhancement good first issue help wanted invalid question refactoring wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.