hastic
/
hastic
4
1
Fork 0
Code Issues 61 Pull Requests Releases Activity
Labels Milestones

detections window begin #63

Merged
glitch4347 merged 3 commits from basic-periodic-update-of-detection-runner-#62 into main 2 years ago
Conversation 0 Commits 3 Files Changed 6
glitch4347 commented 2 years ago (Migrated from github.com)
Owner

Changes

  • new method get_detection_window in AnalyticUnit trait
  • DetectoinRunner takes metric_service as a new param
  • DetectoinRunner runs basic detections and write to console detections

Notes'

  • pattern detection and anomaly detector should return better detection windows: now it's DETECTION_STEP constant and it's wrong
## Changes * new method `get_detection_window` in `AnalyticUnit` trait * `DetectoinRunner` takes `metric_service` as a new param * `DetectoinRunner` runs basic detections and write to console detections ## Notes' * pattern detection and anomaly detector should return better detection windows: now it's `DETECTION_STEP` constant and it's wrong
rozetko (Migrated from github.com) approved these changes 2 years ago

Reviewers

rozetko
The pull request has been merged as 0eff1204f2.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
rozetko
Labels
Apply labels
Clear labels
bug
Something isn't working documentation
Improvements or additions to documentation duplicate
This issue or pull request already exists enhancement
New feature or request good first issue
Good for newcomers help wanted
Extra attention is needed invalid
This doesn't seem right question
Further information is requested refactoring wontfix
This will not be worked on
No Label bug documentation duplicate enhancement good first issue help wanted invalid question refactoring wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'basic-periodic-update-of-detection-runner-#62'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes