It's a bit not coherent that we have events and zoomEvents separately.
I think we shoudl move zoomEvents to events
Maybe as inner property events.zoom or just put all props from zoomEvents to events
It's a bit not coherent that we have `events` and `zoomEvents` separately.
I think we shoudl move `zoomEvents` to `events`
Maybe as inner property `events.zoom` or just put all props from `zoomEvents` to `events`
I agree having both zoomEvents and events is a bit misleading, but I don't think moving zoomEvents into events is a good idea, because they're different entities (events are callbacks, zoomEvents are basically zoom settings)
Maybe we can just name them better? Or do you want to have both zoom settings and callbacks in one place?
@glitch4347
I agree having both `zoomEvents` and `events` is a bit misleading, but I don't think moving `zoomEvents` into `events` is a good idea, because they're different entities (`events` are callbacks, `zoomEvents` are basically zoom settings)
Maybe we can just name them better? Or do you want to have both zoom settings and callbacks in one place?
It's a bit not coherent that we have
eventsandzoomEventsseparately.I think we shoudl move
zoomEventstoeventsMaybe as inner property
events.zoomor just put all props fromzoomEventstoeventsIn this PR would be also good to fix param name
zoomIn?: (range: AxisRange[]) => void,torangesbecause it's multiple ranges@glitch4347
I agree having both
zoomEventsandeventsis a bit misleading, but I don't think movingzoomEventsintoeventsis a good idea, because they're different entities (eventsare callbacks,zoomEventsare basically zoom settings)Maybe we can just name them better? Or do you want to have both zoom settings and callbacks in one place?