OptionsConfig vs optinos #39

Open
opened 8 months ago by glitch4347 · 2 comments
Owner

It's better to make CoreOptions just Options and make config object from what we call now Options.

Motivatiщт for this is that Options is not signe-source of truth and can be constructed and used in wrong manner so CoreOptions actualy is the class which is in use.

I am comming to this because I want to rename datapoints to data and I can't controll hot this type object is constructed, so I need extra logic which I will write in Series (simillar issue with Series like with Options)

It's better to make `CoreOptions` just `Options` and make config object from what we call now `Options`. Motivatiщт for this is that `Options` is not signe-source of truth and can be constructed and used in wrong manner so `CoreOptions` actualy is the class which is in use. I am comming to this because I want to rename `datapoints` to `data` and I can't controll hot this type object is constructed, so I need extra logic which I will write in `Series` (simillar issue with Series like with Options)
Poster
Owner

Is should be Options and Series classes , because it's entity by itself

Is should be `Options` and `Series` classes , because it's entity by itself
Poster
Owner

Also better move Serie to from file types.ts to models/series.ts

Also better move `Serie` to from file `types.ts` to `models/series.ts`
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.