It's better to make CoreOptions just Options and make config object from what we call now Options.
Motivatiщт for this is that Options is not signe-source of truth and can be constructed and used in wrong manner so CoreOptions actualy is the class which is in use.
I am comming to this because I want to rename datapoints to data and I can't controll hot this type object is constructed, so I need extra logic which I will write in Series (simillar issue with Series like with Options)
It's better to make `CoreOptions` just `Options` and make config object from what we call now `Options`.
Motivatiщт for this is that `Options` is not signe-source of truth and can be constructed and used in wrong manner so `CoreOptions` actualy is the class which is in use.
I am comming to this because I want to rename `datapoints` to `data` and I can't controll hot this type object is constructed, so I need extra logic which I will write in `Series` (simillar issue with Series like with Options)
It's better to make
CoreOptions
justOptions
and make config object from what we call nowOptions
.Motivatiщт for this is that
Options
is not signe-source of truth and can be constructed and used in wrong manner soCoreOptions
actualy is the class which is in use.I am comming to this because I want to rename
datapoints
todata
and I can't controll hot this type object is constructed, so I need extra logic which I will write inSeries
(simillar issue with Series like with Options)Is should be
Options
andSeries
classes , because it's entity by itselfAlso better move
Serie
to from filetypes.ts
tomodels/series.ts