eevent callbacks vs abstract #18

Open
opened 4 months ago by glitch4347 · 1 comments
Owner

there is

export type Options = {
  margin?: Margin;
  eventsCallbacks?: {
    zoomIn?: (range: AxisRange[]) => void,
    panning?: (event: { ranges: AxisRange[], d3Event: any }) => void,
    panningEnd?: (range: AxisRange[]) => void,
    zoomOut?: (centers: {x: number, y: number}) => void,
    mouseMove?: (evt: any) => void,

and

protected abstract onMouseMove(): void;

there is recommendatyion to remove these abstract classes

there is ``` export type Options = { margin?: Margin; eventsCallbacks?: { zoomIn?: (range: AxisRange[]) => void, panning?: (event: { ranges: AxisRange[], d3Event: any }) => void, panningEnd?: (range: AxisRange[]) => void, zoomOut?: (centers: {x: number, y: number}) => void, mouseMove?: (evt: any) => void, ``` and ``` protected abstract onMouseMove(): void; ``` there is recommendatyion to remove these abstract classes
Poster
Owner

... and make at least these mnethods deprecated with warting and todo

... and make at least these mnethods deprecated with warting and todo
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.